Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function to get privacy_url #235

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix function to get privacy_url #235

wants to merge 1 commit into from

Conversation

worais
Copy link

@worais worais commented Dec 9, 2024

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

The correct function to get the privacy policy url is this: https://developer.wordpress.org/reference/functions/get_privacy_policy_url/
If you are using a privacy plugin, such as "GDPR Cookie Consent" or other related, the URL can be changed in the plugin itself using the filter: privacy_policy_url, in which case the previous version would not work.

Closes: https://app.clickup.com/t/86duwfma8

How to test the changes in this Pull Request:

  1. Start the onboarding process
  2. Verify that the URL for the privacy policy page is correct

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Fix the URL for the privacy policy page

Copy link

@alexiglesias31 alexiglesias31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants